lordcheng10 commented on code in PR #7456:
URL: https://github.com/apache/inlong/pull/7456#discussion_r1119720991
##########
inlong-sort/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/DynamicSchemaHandleOperator.java:
##########
@@ -314,7 +314,11 @@ private void handleSchemaInfoEvent(TableIdentifier
tableId, Schema schema) {
LOG.warn("Ignore table {} schema change, old:
{} new: {}.",
tableId, dataSchema, latestSchema, e);
blacklist.add(tableId);
- handleDirtyData(jsonNode, jsonNode,
DirtyType.EXTRACT_ROWDATA_ERROR, e, tableId);
+ List<RowData> rowDataForDataSchemaList =
dynamicSchemaFormat.extractRowData(jsonNode,
Review Comment:
1. dynamicSchemaFormat.extractRowData() usually throws an exception when the
schema does not match.
2. Use dataSchema for conversion, usually no exception will be thrown;
3. We can also use try catch to output the error log when an exception is
thrown? @Yizhou-Yang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
