liaorui opened a new pull request, #7541:
URL: https://github.com/apache/inlong/pull/7541

   ### Prepare a Pull Request
   *(Change the title refer to the following example)*
   
   - Title Example: [INLONG-XYZ][Component] Title of the pull request
   
   *(The following *XYZ* should be replaced by the actual [GitHub 
Issue](https://github.com/apache/inlong/issues) number)*
   
   - Fixes #7539
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the 
problem you're trying to solve?*
   
   1. Source cdc connectors like mysql and postgres, pack operation type 
(INSERT、DELETE and UPDATE) into GenericRowData. StarRocks connector is using 
the RowKind of GenericRowData. This row kind is always INSERT.
   
   StarRocks connector should parse this type from RowData with canal-json or 
debezium-json format.
   
   2. When `schema-update.policy` is `LOG_WITH_IGNORE`, but `dirty.ignore` is 
false,  we should not invoke dirty helper to archive dirty data to s3.
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   1. `StarRocksDynamicSinkFunction` class parses the row kind from row data 
just like `doris-connector`.
   2. `StarRocksSinkManager` class has one line new code:  `if 
(dirtySinkHelper.getDirtyOptions().ignoreDirty())`. Only when `dirty.ignore` is 
true, we invoke dirty helper method, else not.
   
   
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [ ] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [ ] This change added tests and can be verified as follows:
   
     *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads 
(10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a follow-up 
issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to