healchow commented on code in PR #7549:
URL: https://github.com/apache/inlong/pull/7549#discussion_r1129017747
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/MySQLDialect.java:
##########
@@ -156,9 +156,10 @@ public List<LogicalTypeRoot> unsupportedTypes() {
@Override
public PreparedStatement setQueryPrimaryKeySql(Connection conn, String
tableIdentifier) throws SQLException {
- PreparedStatement st = conn.prepareStatement(QUERY_PRIMARY_KEY_SQL);
- st.setString(1,
JdbcMultiBatchingComm.getDatabaseNameFromIdentifier(tableIdentifier));
- st.setString(2,
JdbcMultiBatchingComm.getTableNameFromIdentifier(tableIdentifier));
- return st;
+ try (PreparedStatement st =
conn.prepareStatement(QUERY_PRIMARY_KEY_SQL)) {
Review Comment:
@gong Hi, please take a look at this modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
