wangpeix commented on code in PR #7753:
URL: https://github.com/apache/inlong/pull/7753#discussion_r1155479247
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/PulsarSink.java:
##########
@@ -196,7 +196,6 @@ public void destroy() {
AgentUtils.silenceSleepInMs(batchFlushInterval);
}
shutdown = true;
- EXECUTOR_SERVICE.shutdown();
Review Comment:
The `PulsarSink` thread pool is global and, based on the current design,
will always exist throughout the agent's lifecycle. When closed, new tasks
cannot be submitted to the thread pool; think it's okay not to shutdown it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
