vernedeng commented on code in PR #7741:
URL: https://github.com/apache/inlong/pull/7741#discussion_r1155483639
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/redis/RedisDataNodeOperator.java:
##########
@@ -71,6 +77,34 @@ public DataNodeInfo getFromEntity(DataNodeEntity entity) {
@Override
protected void setTargetEntity(DataNodeRequest request, DataNodeEntity
targetEntity) {
RedisDataNodeRequest redisDataNodeRequest = (RedisDataNodeRequest)
request;
+
+ RedisClusterMode clusterMode =
RedisClusterMode.of(redisDataNodeRequest.getClusterMode());
+
+ switch (clusterMode) {
+ case STANDALONE:
+ String host = redisDataNodeRequest.getHost();
+ Preconditions.expectNotBlank(host, "Redis host cannot be
empty");
+ Integer port = redisDataNodeRequest.getPort();
+ expectTrue(
+ port != null && port > 1 && port < PORT_MAX_VALUE,
Review Comment:
One of conditions is **_port > 1_**, but the error message is **_must be
greater than 0_**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
