[GitHub] [inlong] vernedeng commented on a diff in pull request #7770: [INLONG-7769][DataProxy] Fix NPE when request Inlong Manager failed

Tue, 04 Apr 2023 02:55:45 -0700 


vernedeng commented on code in PR #7770:
URL: https://github.com/apache/inlong/pull/7770#discussion_r1157012026


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/RemoteConfigManager.java:
##########
@@ -205,6 +205,12 @@ private boolean reloadDataProxyConfig(String clusterName, 
String clusterTag, Str
             LOGGER.info("start to request {} to get config info with params 
{}", url, request);
             CloseableHttpResponse response = httpClient.execute(httpPost);
             String returnStr = EntityUtils.toString(response.getEntity());
+
+            if (response.getStatusLine().getStatusCode() != 200) {

Review Comment:
   <img width="981" alt="image" 
src="https://user-images.githubusercontent.com/45282474/229756142-71345078-3034-4d0b-81e7-efb84ef11e4b.png";>
   
   The constuctor of HttpResponse requires statusline not null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to