duowan1520 commented on code in PR #7694:
URL: https://github.com/apache/inlong/pull/7694#discussion_r1160569657


##########
inlong-sort/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/source/reader/MySqlRecordEmitter.java:
##########
@@ -112,7 +119,8 @@ public void emitRecord(SourceRecord element, 
SourceOutput<T> output, MySqlSplitS
             for (TableChange tableChange : changes) {
                 
splitState.asBinlogSplitState().recordSchema(tableChange.getId(), tableChange);
                 if (includeSchemaChanges) {
-                    outputDdlElement(element, output, splitState, tableChange);
+                    TableChange newTableChange = 
ColumnFilterUtil.createTableChange(tableChange, columnNameFilter);

Review Comment:
   Hi. There is a premise here. When the task sets the 
`debezium.column.include.list/debezium.column.exclude.list` parameter, it means 
that the task will only focus on those specified columns. When the filtered 
columns have dml and ddl changes , whose changes need to be ignored.
   
   Therefore, when the columnFilter is applied here, it is expected that the 
schema will only retain the columns required by the task. In this way, the 
downstream can also filter out the columns that are not concerned in the ddl 
statement based on the new schema (todo)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to