featzhang commented on code in PR #7793:
URL: https://github.com/apache/inlong/pull/7793#discussion_r1161069764


##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongStreamController.java:
##########
@@ -183,4 +191,22 @@ public Response<List<StreamField>> 
parseFields(@RequestBody ParseFieldRequest pa
         return Response.success(streamService.parseFields(parseFieldRequest));
     }
 
+    @RequestMapping(value = "/stream/fieldsImportTemplate", method = 
RequestMethod.GET)
+    @ApiOperation(value = "Download fields import template")
+    public void downloadFieldsImportTemplate(HttpServletResponse response) {

Review Comment:
   When using a response to download files, HttpServletResponse is used to 
output the response's content, status code, and headers. I understand that the 
return value of this method has no effect. Instead, the file cannot be 
processed when the spring converters is called to output the content:
   
   No converter for [class org.apache.inlong.manager.pojo.common.Response] with 
preset Content-Type 
'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to