vernedeng commented on code in PR #7824:
URL: https://github.com/apache/inlong/pull/7824#discussion_r1163498744
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/ck/ClickHouseSqlBuilder.java:
##########
@@ -66,7 +67,10 @@ public static String buildCreateTableSql(ClickHouseTableInfo
table) {
}
// Construct columns and partition columns
sql.append(buildCreateColumnsSql(table.getFieldInfoList()));
- if (StringUtils.isNotEmpty(table.getEngine())) {
+ if (StringUtils.isNotBlank(table.getEngine()) &&
Objects.equals("ReplicatedMergeTree", table.getEngine())) {
+ sql.append(
+ " ENGINE =
ReplicatedMergeTree('/clickhouse/tables/{shard}/{database}/{table}/data',
'{replica}')");
Review Comment:
Is there only one engine?
I think it's better to make an engine emun, instead of making branch for
each engine type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
