xuehuanran commented on code in PR #7933:
URL: https://github.com/apache/inlong/pull/7933#discussion_r1187133728
##########
inlong-tubemq/tubemq-client-twins/tubemq-client-go/util/util.go:
##########
@@ -147,3 +150,17 @@ func Join(m map[string]string, step1 string, step2 string)
string {
}
return s
}
+
+func NewClientID(group string, clientID *uint64, tubeMQClientVersion string)
string {
+ res := ""
Review Comment:
I guess that the consumer author's approach was to use the `clientID`
variable declared in the `client` package to handle situations where there are
multiple `producers`/`consumers` in the same client process. In commit
[b86910a](https://github.com/apache/inlong/pull/7933/commits/a9073066c0e062fb33b85d02cef0e3e3b38d10d3),
I updated the returned `clientID` to `clientName` to avoid potential
misunderstandings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
