leezng commented on code in PR #8053: URL: https://github.com/apache/inlong/pull/8053#discussion_r1198817698
########## inlong-dashboard/src/ui/components/EditableTable/index.tsx: ########## @@ -69,6 +69,10 @@ export interface EditableTableProps // Can add a new line? Default: true. canAdd?: boolean; canBatchAdd?: boolean; Review Comment: `EditableTable` as a base component, I don't think `upsetByFieldKey`, `fieldNameKey`, ... such parameters with obvious meanings. The parameters of `EditableTable` should be abstracted, which is the common capability of the underlying component, and the parameters added above should be implemented in the upper component. For example, this PR adds a new capability to EditableTable, we can define it as an attribute related to append or overwrite, and the impact on fieldName and fieldKey should be implemented in the upper-level business component of Sink. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
