vernedeng commented on code in PR #8081:
URL: https://github.com/apache/inlong/pull/8081#discussion_r1205192011
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -322,9 +323,11 @@ public PageResult<? extends StreamSink>
listByCondition(SinkPageRequest request,
PageHelper.startPage(request.getPageNum(), request.getPageSize());
OrderFieldEnum.checkOrderField(request);
OrderTypeEnum.checkOrderType(request);
- List<StreamSinkEntity> entityPage =
sinkMapper.selectByCondition(request);
+ Page<StreamSinkEntity> entityPage = (Page<StreamSinkEntity>)
sinkMapper.selectByCondition(request);
Review Comment:
Please use pageHelper to do paging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
