chestnut-c commented on code in PR #8115:
URL: https://github.com/apache/inlong/pull/8115#discussion_r1209120934
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java:
##########
@@ -563,6 +564,7 @@ private static List<FieldInfo>
parseFieldInfos(List<StreamField> streamFields, S
*/
private static Map<String, String> parseProperties(Map<String, Object>
properties) {
return properties.entrySet().stream()
+ .filter(v -> Objects.nonNull(v.getValue()))
Review Comment:
> Suggest use `StringUtils.isNotBank()`.
Value is of type Object，so i use Objects.nonNull(Object obj)
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/LoadNodeUtils.java:
##########
@@ -117,6 +118,7 @@ public static LoadNode createLoadNode(StreamSink
streamSink, Map<String, StreamF
.collect(Collectors.toList());
List<FieldRelation> fieldRelations =
parseSinkFields(streamSink.getSinkFieldList(), constantFieldMap);
Map<String, String> properties =
streamSink.getProperties().entrySet().stream()
+ .filter(v -> Objects.nonNull(v.getValue()))
Review Comment:
> Suggest use `StringUtils.isNotBank()`.
Value is of type Object，so i use Objects.nonNull(Object obj)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
