chestnut-c commented on code in PR #8155:
URL: https://github.com/apache/inlong/pull/8155#discussion_r1217820971


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/FieldFormatUtils.java:
##########
@@ -78,4 +89,59 @@ public static String createStructFormat(List<Element> 
elements) {
     public static StructFormat parseStructFormat(String formatJson) {
         return JsonUtils.parseObject(formatJson, StructFormat.class);
     }
+
+    /**
+     * Parse format
+     *
+     * @param serializationType data serialization, support: csv, json, canal, 
avro, etc
+     * @param wrapWithInlongMsg whether wrap content with {@link 
InLongMsgFormat}
+     * @param separatorStr the separator of data content
+     * @param ignoreParseErrors whether ignore deserialization error data
+     * @return the format for serialized content
+     */
+    public static Format parsingFormat(

Review Comment:
   > I think this function has nothing to do with `FieldFormatUtils` and should 
be placed in `ExtractNodeProvider`
   
   FieldFormatUtils also contains Format, but it is not very accurate, it can 
be placed in ExtractNodeProvider



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to