fuweng11 commented on code in PR #8184:
URL: https://github.com/apache/inlong/pull/8184#discussion_r1221334159


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/pojo/IdTopicConfig.java:
##########
@@ -78,16 +85,23 @@ public void setInlongGroupIdAndStreamId(String 
inlongGroupId, String inlongStrea
 
     public String getPulsarTopicName(String clusterTenant, String 
clusterNameSpace) {
         StringBuilder builder = new StringBuilder(256);
-        if (clusterTenant != null) {
-            builder.append(clusterTenant).append("/");
-        }
-        String namespace = clusterNameSpace;
-        if (namespace == null) {
-            namespace = this.nameSpace;
+        // build tenant
+        if (StringUtils.isBlank(tenant)) {

Review Comment:
   ```suggestion
            if (StringUtils.isNotBlank(tenant)) {
               builder.append(tenant).append("/");
           }else if (StringUtils.isNotBlank(clusterTenant)) {
               builder.append(clusterTenant).append("/");
           } else {
               builder.append(DEFAULT_PULSAR_TENANT).append("/");
           }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to