fuweng11 commented on code in PR #8201:
URL: https://github.com/apache/inlong/pull/8201#discussion_r1224150325
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/UserServiceImpl.java:
##########
@@ -167,15 +167,15 @@ public UserInfo getById(Integer userId, String
currentUser) {
result.setAccountType(entity.getAccountType());
result.setVersion(entity.getVersion());
- if (StringUtils.isNotBlank(entity.getSecretKey()) &&
StringUtils.isNotBlank(entity.getPublicKey())) {
+ if (StringUtils.isNotBlank(entity.getSecretKey())/* &&
StringUtils.isNotBlank(entity.getPublicKey()) */) {
try {
// decipher according to stored key version
// note that if the version is null then the string is treated
as unencrypted plain text
Integer version = entity.getEncryptVersion();
byte[] secretKeyBytes =
AESUtils.decryptAsString(entity.getSecretKey(), version);
- byte[] publicKeyBytes =
AESUtils.decryptAsString(entity.getPublicKey(), version);
+ // byte[] publicKeyBytes =
AESUtils.decryptAsString(entity.getPublicKey(), version);
Review Comment:
` byte[] publicKeyBytes = AESUtils.decryptAsString(entity.getPublicKey(),
version);`
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/UserServiceImpl.java:
##########
@@ -167,15 +167,15 @@ public UserInfo getById(Integer userId, String
currentUser) {
result.setAccountType(entity.getAccountType());
result.setVersion(entity.getVersion());
- if (StringUtils.isNotBlank(entity.getSecretKey()) &&
StringUtils.isNotBlank(entity.getPublicKey())) {
+ if (StringUtils.isNotBlank(entity.getSecretKey())/* &&
StringUtils.isNotBlank(entity.getPublicKey()) */) {
try {
// decipher according to stored key version
// note that if the version is null then the string is treated
as unencrypted plain text
Integer version = entity.getEncryptVersion();
byte[] secretKeyBytes =
AESUtils.decryptAsString(entity.getSecretKey(), version);
- byte[] publicKeyBytes =
AESUtils.decryptAsString(entity.getPublicKey(), version);
+ // byte[] publicKeyBytes =
AESUtils.decryptAsString(entity.getPublicKey(), version);
result.setSecretKey(new String(secretKeyBytes,
StandardCharsets.UTF_8));
- result.setPublicKey(new String(publicKeyBytes,
StandardCharsets.UTF_8));
+ // result.setPublicKey(new String(publicKeyBytes,
StandardCharsets.UTF_8));
Review Comment:
`result.setPublicKey(new String(publicKeyBytes, StandardCharsets.UTF_8));`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
