chestnut-c commented on code in PR #8223:
URL: https://github.com/apache/inlong/pull/8223#discussion_r1227933811
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/base/ExtractNodeProvider.java:
##########
@@ -60,8 +61,23 @@ public interface ExtractNodeProvider extends NodeProvider {
*/
default List<FieldInfo> parseStreamFieldInfos(List<StreamField>
streamFields, String nodeId) {
// Filter constant fields
+ return parseStreamFieldInfos(streamFields, nodeId, null);
Review Comment:
> Why is the `dataTypeMappingStrategy` set to empty? I don't think you
should do this if you want to use the original fieldtype. There should be a
class to handle cases where the current type does not support mapping.
Overload the current method, I think both will work，currently in an
overloaded way, to avoid instantiation and introduce some unnecessary
instances, and compatible with the previous way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
