fuweng11 commented on code in PR #8223:
URL: https://github.com/apache/inlong/pull/8223#discussion_r1227964120
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/base/ExtractNodeProvider.java:
##########
@@ -60,8 +61,23 @@ public interface ExtractNodeProvider extends NodeProvider {
*/
default List<FieldInfo> parseStreamFieldInfos(List<StreamField>
streamFields, String nodeId) {
// Filter constant fields
+ return parseStreamFieldInfos(streamFields, nodeId, null);
+ }
+
+ /**
+ * Parse StreamFieldInfos
+ *
+ * @param streamFields The stream fields
+ * @param nodeId The node id
+ * @param dataTypeMappingStrategy The data type mapping operation strategy
+ * @return FieldInfo list
+ */
+ default List<FieldInfo> parseStreamFieldInfos(List<StreamField>
streamFields, String nodeId,
Review Comment:
This method is redundant.Just rewrite
`parseStreamFieldInfos(List<StreamField> streamFields, String nodeId)`
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/datatype/datasource/BaseDataType.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.datatype.datasource;
+
+/**
+ * The interface of base data type mapping
+ */
+public interface BaseDataType {
Review Comment:
Maybe `BaseFieldType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
