[GitHub] [inlong] healchow commented on a diff in pull request #8344: [INLONG-8343][Dashboard] Increase the length of the field for creating MySQL varchar types to 16383

Wed, 28 Jun 2023 20:38:46 -0700 


healchow commented on code in PR #8344:
URL: https://github.com/apache/inlong/pull/8344#discussion_r1246058691


##########
inlong-dashboard/src/plugins/sinks/defaults/MySQL.ts:
##########
@@ -47,7 +47,7 @@ const fieldTypesConf = {
   TIME: () => '',
   DATETIME: () => '',
   CHAR: (m, d) => (1 <= m && m <= 255 ? '' : '1<=M<=255'),
-  VARCHAR: (m, d) => (1 <= m && m <= 255 ? '' : '1<=M<=255'),
+  VARCHAR: (m, d) => (1 <= m && m <= 16383 ? '' : '1<=M<=16383'),

Review Comment:
   I found that in MySQL 8.0.30 on macOS, the default charset is utf8mb4, in 
this case, the max length of the CHAR type is 255, and the max length of the 
VARCHAR type is 16383, so this PR is good to me.
   
   Charset:
   
   
![image](https://github.com/apache/inlong/assets/31994335/e4514b20-1af0-48ec-b189-ce8913f838f9)
   
   CHAR type:
   
   <img width="827" alt="image" 
src="https://github.com/apache/inlong/assets/31994335/48b19e91-8184-489c-934d-c93663857162";>
   
   VARCHAR type:
   <img width="878" alt="image" 
src="https://github.com/apache/inlong/assets/31994335/31983eea-5cd3-48fb-adcf-c789b902218b";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to