vernedeng commented on code in PR #8397:
URL: https://github.com/apache/inlong/pull/8397#discussion_r1250221850
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/audit/AuditInfo.java:
##########
@@ -30,12 +30,15 @@ public class AuditInfo {
private String logTs;
@ApiModelProperty(value = "Audit count")
private Long count;
+ @ApiModelProperty(value = "Audit delay")
+ private Long delay;
public AuditInfo() {
}
- public AuditInfo(String logTs, Long count) {
+ public AuditInfo(String logTs, Long count, Long delay) {
Review Comment:
what if count or delay is null?
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AuditServiceImpl.java:
##########
@@ -268,6 +271,7 @@ private List<String> getAuditIds(String groupId, String
streamId, String sinkNod
if (sinkNodeType == null) {
auditSet.add(getAuditId(ClusterType.DATAPROXY, true));
} else {
+ auditSet.add(getAuditId(sinkNodeType, true));
Review Comment:
Audit supports not only send or receive, please make this interface more
common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
