leezng commented on code in PR #8487:
URL: https://github.com/apache/inlong/pull/8487#discussion_r1257972224
##########
inlong-dashboard/src/ui/components/FieldList/DetailModal.tsx:
##########
@@ -95,6 +95,65 @@ const Comp: React.FC<Props> = ({
}),
);
+ const sinkFieldList: ColumnsItemProps[] = [
+ {
+ title: i18n.t('meta.Sinks.SourceFieldName'),
+ dataIndex: 'sourceFieldName',
+ type: 'input',
+ rules: [
+ { required: true },
+ {
+ pattern: /^[a-zA-Z_][a-zA-Z0-9_]*$/,
+ message: i18n.t('meta.Stream.FieldNameRule'),
+ },
+ ],
+ props: (text, record) => ({
Review Comment:
If props does not need to rely on function parameters `text` and `record`,
use them directly:
```
props: {
disabled: true
}
```
This allows for better performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
