EMsnap commented on code in PR #8607:
URL: https://github.com/apache/inlong/pull/8607#discussion_r1281452279
##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/debezium/table/RowDataDebeziumDeserializeSchema.java:
##########
@@ -797,7 +797,32 @@ private Object getValueWithSchema(Object fieldValue,
String schemaName) {
@Override
public void deserialize(SourceRecord record, Collector<RowData> out)
throws Exception {
- deserialize(record, out);
+ Envelope.Operation op = Envelope.operationFor(record);
Review Comment:
There are some duplicate code in public void deserialize(SourceRecord
record, Collector<RowData> out,TableChange tableSchema) , maybe reuse them is a
better idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
