e-mhui commented on code in PR #8746:
URL: https://github.com/apache/inlong/pull/8746#discussion_r1295735791
##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/postgres-cdc/src/main/java/org/apache/inlong/sort/cdc/postgres/table/PostgreSQLReadableMetaData.java:
##########
@@ -467,6 +478,35 @@ private static List<String> getPkNames(@Nullable
TableChange tableSchema) {
return tableSchema.getTable().primaryKeyColumnNames();
}
+ /**
+ * get a map about column name and type
+ * @param tableSchema
+ * @return map of field name and field type
+ */
+ private static Map<String, String> getPostGreType(@Nullable
TableChanges.TableChange tableSchema) {
+ if (tableSchema == null) {
+ return null;
+ }
Review Comment:
The `getPostGreType` method has similar implementations in MySQL
CDC(`getMysqlType`) and Oracle CDC (`getOracleType`). Can we extract them and
put them in a util class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
