vernedeng commented on code in PR #8795:
URL: https://github.com/apache/inlong/pull/8795#discussion_r1303741145
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -700,6 +703,39 @@ public Boolean updateAfterApprove(List<SinkApproveDTO>
approveList, String opera
return true;
}
+ @Override
+ public boolean addFields(StreamSinkEntity sinkEntity, List<SinkField>
sinkFieldList) {
+ Set<String> existFields =
sinkFieldMapper.selectBySinkId(sinkEntity.getId()).stream()
+
.map(StreamSinkFieldEntity::getFieldName).collect(Collectors.toSet());
+
+ LOGGER.debug("begin to save sink fields={}", sinkFieldList);
+ if (CollectionUtils.isEmpty(sinkFieldList)) {
+ return true;
+ }
+ List<StreamSinkFieldEntity> needAddFieldList = new ArrayList<>();
+ for (SinkField fieldInfo : sinkFieldList) {
+ if (existFields.contains(fieldInfo.getFieldName())) {
+ continue;
+ }
+ StreamSinkFieldEntity fieldEntity =
CommonBeanUtils.copyProperties(fieldInfo,
+ StreamSinkFieldEntity::new);
+ if (StringUtils.isEmpty(fieldEntity.getFieldComment())) {
+ fieldEntity.setFieldComment(fieldEntity.getFieldName());
+ }
+ fieldEntity.setInlongGroupId(sinkEntity.getInlongGroupId());
+ fieldEntity.setInlongStreamId(sinkEntity.getInlongStreamId());
+ fieldEntity.setSinkType(sinkEntity.getSinkType());
+ fieldEntity.setSinkId(sinkEntity.getId());
+ fieldEntity.setIsDeleted(InlongConstants.UN_DELETED);
+ needAddFieldList.add(fieldEntity);
+ }
+ if (CollectionUtils.isNotEmpty(needAddFieldList)) {
+ sinkFieldMapper.insertAll(needAddFieldList);
Review Comment:
ditto
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -700,6 +703,39 @@ public Boolean updateAfterApprove(List<SinkApproveDTO>
approveList, String opera
return true;
}
+ @Override
+ public boolean addFields(StreamSinkEntity sinkEntity, List<SinkField>
sinkFieldList) {
+ Set<String> existFields =
sinkFieldMapper.selectBySinkId(sinkEntity.getId()).stream()
+
.map(StreamSinkFieldEntity::getFieldName).collect(Collectors.toSet());
+
+ LOGGER.debug("begin to save sink fields={}", sinkFieldList);
+ if (CollectionUtils.isEmpty(sinkFieldList)) {
+ return true;
Review Comment:
Please add more debug log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
