fuweng11 commented on code in PR #9029:
URL: https://github.com/apache/inlong/pull/9029#discussion_r1350152957
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/cls/ClsResourceOperator.java:
##########
@@ -136,14 +169,34 @@ private ClsClient getClsClient(ClsDataNodeDTO
clsDataNode) {
/**
* Create topic index by tokenizer
*/
- private void createTopicIndex(SinkInfo sinkInfo) throws BusinessException {
+ private void createTopicIndex(SinkInfo sinkInfo, ClsDataNodeDTO
clsDataNode) throws BusinessException {
+
ClsSinkDTO clsSinkDTO = JsonUtils.parseObject(sinkInfo.getExtParams(),
ClsSinkDTO.class);
- if (StringUtils.isNotBlank(clsSinkDTO.getTokenizer())) {
- LOG.warn("topic {} tokenizer is empty", clsSinkDTO.getTopicName());
+ if (StringUtils.isBlank(clsSinkDTO.getTokenizer())) {
+ LOG.warn("topic {} tokenizer is blank", clsSinkDTO.getTopicName());
+ return;
+ }
+ FullTextInfo topicIndexFullText = getTopicIndexFullText(sinkInfo,
clsDataNode);
+ if (ObjectUtils.anyNotNull(topicIndexFullText)) {
+ // if topic index exist,update
+ updateTopicIndex(sinkInfo, clsDataNode);
return;
}
- ClsDataNodeDTO clsDataNode = getClsDataNode(sinkInfo);
ClsClient clsClient = getClsClient(clsDataNode);
+ CreateIndexRequest req = getCreateIndexRequest(clsSinkDTO);
+ try {
+ clsClient.CreateIndex(req);
Review Comment:
Please add log for `CreateIndexResponse`.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/cls/ClsResourceOperator.java:
##########
@@ -152,15 +205,87 @@ private void createTopicIndex(SinkInfo sinkInfo) throws
BusinessException {
CreateIndexRequest req = new CreateIndexRequest();
req.setTopicId(clsSinkDTO.getTopicId());
req.setRule(ruleInfo);
+ return req;
+ }
+
+ private void updateTopicIndex(SinkInfo sinkInfo, ClsDataNodeDTO
clsDataNode) {
+ ClsClient clsClient = getClsClient(clsDataNode);
+ ClsSinkDTO clsSinkDTO = JsonUtils.parseObject(sinkInfo.getExtParams(),
ClsSinkDTO.class);
+ RuleInfo ruleInfo = new RuleInfo();
+ FullTextInfo fullTextInfo1 = new FullTextInfo();
+ fullTextInfo1.setTokenizer(clsSinkDTO.getTokenizer());
+ ruleInfo.setFullText(fullTextInfo1);
+
+ ModifyIndexRequest req = new ModifyIndexRequest();
+ req.setTopicId(clsSinkDTO.getTopicId());
+ req.setRule(ruleInfo);
try {
- clsClient.CreateIndex(req);
+ clsClient.ModifyIndex(req);
} catch (TencentCloudSDKException e) {
- String errMsg = "Create cls topic index failed: " + e.getMessage();
+ String errMsg = "update cls topic index failed: " + e.getMessage();
LOG.error(errMsg, e);
sinkService.updateStatus(sinkInfo.getId(),
SinkStatus.CONFIG_FAILED.getCode(), errMsg);
throw new BusinessException(errMsg);
}
- LOG.info("topic {} create index success tokenizer is {}",
clsSinkDTO.getTopicName(), clsSinkDTO.getTokenizer());
Review Comment:
LOG.info("update index success for topic = {}, tokenizer = {}",
clsSinkDTO.getTopicName(),,clsSinkDTO.getTokenizer());
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/cls/ClsResourceOperator.java:
##########
@@ -152,15 +205,87 @@ private void createTopicIndex(SinkInfo sinkInfo) throws
BusinessException {
CreateIndexRequest req = new CreateIndexRequest();
req.setTopicId(clsSinkDTO.getTopicId());
req.setRule(ruleInfo);
+ return req;
+ }
+
+ private void updateTopicIndex(SinkInfo sinkInfo, ClsDataNodeDTO
clsDataNode) {
+ ClsClient clsClient = getClsClient(clsDataNode);
+ ClsSinkDTO clsSinkDTO = JsonUtils.parseObject(sinkInfo.getExtParams(),
ClsSinkDTO.class);
+ RuleInfo ruleInfo = new RuleInfo();
+ FullTextInfo fullTextInfo1 = new FullTextInfo();
+ fullTextInfo1.setTokenizer(clsSinkDTO.getTokenizer());
+ ruleInfo.setFullText(fullTextInfo1);
+
+ ModifyIndexRequest req = new ModifyIndexRequest();
+ req.setTopicId(clsSinkDTO.getTopicId());
+ req.setRule(ruleInfo);
try {
- clsClient.CreateIndex(req);
+ clsClient.ModifyIndex(req);
Review Comment:
Please add log for `ModifyIndexResponse`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
