liaosunny123 commented on PR #9021: URL: https://github.com/apache/inlong/pull/9021#issuecomment-1754883340
> > > Please add a description on what problem the pr solves, btw why add a class that's not used ? > > > > The mysql test container existed before this pr and there are some unneed codes, so I remove them. > > > > As for MSSQL test container, it can help others write sqlserver test container for sqlserver Connector in flink 1.13. Just like the Mysql test container in flink 1.13 end to end test which are not used. > > > > These container are tested in flink 1.15 end to end test. > > Thanks for the contribution, but we only submit code that's needed for a feature or so. Maybe you could submit this class when implementing sqlserver for flink1.13 (because U need to UT this in flink 1.13) sqlserver is implemented in flink 1.13, it lacks UT. Do you mean when adding sqlserver Connector of flink 1.13 UT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
