yunqingmoswu commented on code in PR #9080:
URL: https://github.com/apache/inlong/pull/9080#discussion_r1366374292
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/PulsarTableOptions.java:
##########
@@ -282,4 +282,11 @@ private PulsarTableOptions() {
.booleanType()
.defaultValue(true)
.withDescription("Indicate if the table is an explicit
Flink table.");
+
+ public static final ConfigOption<Boolean> GENERIC = ConfigOptions
Review Comment:
What the meaning if false?Maybe it is needed a clearer definition.
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/PulsarTableOptions.java:
##########
@@ -89,7 +89,7 @@ private PulsarTableOptions() {
.build());
public static final ConfigOption<String> SOURCE_START_FROM_MESSAGE_ID =
Review Comment:
It is recommend to keep the meaning between the name of constant and the
`ConfigOptions.key`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
