EMsnap commented on code in PR #9119:
URL: https://github.com/apache/inlong/pull/9119#discussion_r1372790982
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/db/RocksDbImp.java:
##########
@@ -160,23 +160,12 @@ public KeyValueEntity get(String key) {
@Override
public CommandEntity getCommand(String commandId) {
- try {
- byte[] bytes = db.get(columnHandlesMap.get(commandFamilyName),
commandId.getBytes());
- return bytes == null ? null : GSON.fromJson(new String(bytes),
CommandEntity.class);
- } catch (Exception e) {
- throw new RuntimeException("get command value error", e);
- }
+ return null;
}
@Override
public CommandEntity putCommand(CommandEntity entity) {
- requireNonNull(entity);
- try {
- db.put(columnHandlesMap.get(commandFamilyName),
entity.getId().getBytes(), GSON.toJson(entity).getBytes());
- } catch (Exception e) {
- throw new RuntimeException("put value to rocks db error", e);
- }
- return entity;
+ return null;
Review Comment:
Sorry but why return null here? This db store cmd from manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
