EMsnap commented on code in PR #9135:
URL: https://github.com/apache/inlong/pull/9135#discussion_r1374035999


##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/utils/file/MatchPoint.java:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.plugin.utils.file;
+
+public class MatchPoint {
+
+    String str;
+    int start;
+    int end;
+
+    MatchPoint(String str1, int start1, int end1) {

Review Comment:
   please don't use number in parameter name 



##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/utils/file/FilePathUtil.java:
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.plugin.utils.file;
+
+import org.apache.commons.lang.StringUtils;
+
+import java.io.File;
+import java.util.ArrayList;
+
+public class FilePathUtil {
+
+    private static final String YEAR = "YYYY";
+    private static final String MONTH = "MM";
+    private static final String DAY = "DD";
+    private static final String HOUR = "hh";
+
+    public static ArrayList<String> cutDirectory(String directory) {
+        String baseDirectory;
+        String regixDirecotry;
+        String fileName;
+
+        File file = new File(directory);
+        fileName = file.getName();
+
+        int fileNameIndex = directory.length() - fileName.length() - 1;
+        String sign = "\\^$*+?{(|[.";
+        String range = "+?*{";
+
+        int regixDirecotryIndex = StringUtils.indexOfAny(directory, sign);
+        if (regixDirecotryIndex != -1
+                && directory.charAt(regixDirecotryIndex) == '.') {
+            if (regixDirecotryIndex != directory.length() - 1) {
+                char c = directory.charAt(regixDirecotryIndex + 1);
+                if (StringUtils.indexOf(range, c) == -1) {
+                    regixDirecotryIndex = StringUtils.indexOfAny(directory,
+                            sign.substring(0, sign.length() - 1));
+                }
+            }
+        }
+        if (regixDirecotryIndex < fileNameIndex) {
+            int regixDirecotryBeginIndex = directory.lastIndexOf('/',
+                    regixDirecotryIndex);
+            if (regixDirecotryBeginIndex == -1) {
+                baseDirectory = directory.substring(0, fileNameIndex);
+                regixDirecotry = "";
+            } else {
+
+                regixDirecotry = directory.substring(
+                        regixDirecotryBeginIndex + 1, fileNameIndex);
+                if (regixDirecotryBeginIndex == 0) {
+                    baseDirectory = "/";
+                } else {
+                    baseDirectory = directory.substring(0,
+                            regixDirecotryBeginIndex);
+                }
+            }
+        } else {
+            baseDirectory = directory.substring(0, fileNameIndex);
+            regixDirecotry = "";
+        }
+
+        ArrayList<String> ret = new ArrayList<String>();
+        ret.add(baseDirectory);
+        ret.add(regixDirecotry);
+        ret.add(fileName);
+        return ret;
+    }
+
+    public static ArrayList<String> getDirectoryLayers(String directory) {
+        String baseDirectory;
+        String regixDirectory;
+        String fileName;
+
+        File file = new File(directory);
+        fileName = file.getName();
+
+        int fileNameIndex = directory.length() - fileName.length() - 1;
+        String sign = "\\^$*+?{(|[.";
+
+        String range = "+?*{";
+
+        int regixDirecotryIndex = StringUtils.indexOfAny(directory, sign);
+        if (regixDirecotryIndex != -1
+                && directory.charAt(regixDirecotryIndex) == '.') {
+            if (regixDirecotryIndex != directory.length() - 1) {
+                char c = directory.charAt(regixDirecotryIndex + 1);
+                if (StringUtils.indexOf(range, c) == -1) {
+                    regixDirecotryIndex = StringUtils.indexOfAny(directory,
+                            sign.substring(0, sign.length() - 1));
+                }
+            }
+        }
+        if (regixDirecotryIndex < fileNameIndex) {
+            int regixDirecotryBeginIndex = directory.lastIndexOf('/',
+                    regixDirecotryIndex);
+            if (regixDirecotryBeginIndex == -1) {
+                baseDirectory = directory.substring(0, fileNameIndex);
+                regixDirectory = "";
+            } else {
+                regixDirectory = directory.substring(
+                        regixDirecotryBeginIndex + 1, fileNameIndex);
+                if (regixDirecotryBeginIndex == 0) {
+                    baseDirectory = "/";
+                } else {
+                    baseDirectory = directory.substring(0,
+                            regixDirecotryBeginIndex);
+                }
+            }
+        } else {
+            baseDirectory = directory.substring(0, fileNameIndex);
+            regixDirectory = "";
+        }
+
+        int[] indexes = new int[]{
+                (baseDirectory.contains(YEAR) ? baseDirectory.indexOf(YEAR) : 
Integer.MAX_VALUE),
+                (baseDirectory.contains(MONTH) ? baseDirectory.indexOf(MONTH) 
: Integer.MAX_VALUE),
+                (baseDirectory.contains(DAY) ? baseDirectory.indexOf(DAY) : 
Integer.MAX_VALUE),
+                (baseDirectory.contains(HOUR) ? baseDirectory.indexOf(HOUR) : 
Integer.MAX_VALUE)};
+
+        int minIndex = Integer.MAX_VALUE;
+        for (int i = 0; i < indexes.length; i++) {
+            if (minIndex > indexes[i]) {
+                minIndex = indexes[i];
+            }
+        }
+
+        if (minIndex != Integer.MAX_VALUE) {
+            int lastIndex = baseDirectory.lastIndexOf('/', minIndex);
+            if (regixDirectory.length() > 0) {
+                regixDirectory = baseDirectory.substring(lastIndex + 1, 
baseDirectory.length())
+                        + File.separator + regixDirectory;
+            } else {
+                regixDirectory = baseDirectory.substring(lastIndex + 1, 
baseDirectory.length());
+            }
+            baseDirectory = baseDirectory.substring(0, lastIndex);
+        }
+
+        ArrayList<String> ret = new ArrayList<String>();
+        ret.add(baseDirectory);
+        ret.add(regixDirectory);
+        ret.add(fileName);
+        return ret;
+    }
+
+    public static boolean isSameDir(String fileName1, String fileName2) {
+        ArrayList<String> ret1 = FilePathUtil.cutDirectory(fileName1);
+        ArrayList<String> ret2 = FilePathUtil.cutDirectory(fileName2);
+        if (ret1.get(0).equals(ret2.get(0))) {

Review Comment:
   return ret1.get(0).equals(ret2.get(0))



##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/utils/file/Files.java:
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.plugin.utils.file;
+
+import org.apache.inlong.agent.utils.file.FileFinder;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Paths;
+import java.nio.file.attribute.BasicFileAttributes;
+
+public class Files {
+
+    /**
+     * Finds files or sub directories within a given base directory.
+     *
+     * @param baseDirectory A path string representing a directory to search 
within.
+     * @return A {@link 
org.apache.inlong.agent.plugin.utils.FileFinder}-Object to specify the search
+     *     parameters using a builder pattern.
+     */
+    public static FileFinder find(String baseDirectory) {
+        return find(new File(baseDirectory));
+    }
+
+    /**
+     * Finds files or sub directories within a given base directory.
+     *
+     * @param baseDirectory A path as {@link File} object to search within.
+     * @return A {@link org.apache.inlong.agent.plugin.utils.FileFinder} 
object to specify the search
+     *     parameters using a builder pattern.
+     */
+    public static FileFinder find(File baseDirectory) {
+        return new FileFinder(baseDirectory);
+    }
+
+    public static long getFileCreationTime(String fileName) {
+        long createTime = 0L;
+        try {
+            createTime = 
java.nio.file.Files.readAttributes(Paths.get(fileName),
+                    BasicFileAttributes.class).creationTime().toMillis();
+        } catch (IOException ignore) {
+
+        }
+        return createTime;
+    }
+
+    public static long getFileLastModifyTime(String fileName) {
+        long lastModify = 0L;
+        try {
+            lastModify = 
java.nio.file.Files.getLastModifiedTime(Paths.get(fileName)).toMillis();
+        } catch (IOException ioe) {

Review Comment:
   catch without handle 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to