EMsnap commented on code in PR #9164:
URL: https://github.com/apache/inlong/pull/9164#discussion_r1376973002
##########
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/task/PositionManager.java:
##########
@@ -44,14 +44,14 @@ public class PositionManager extends AbstractDaemon {
private static final Logger LOGGER =
LoggerFactory.getLogger(PositionManager.class);
private static volatile PositionManager positionManager = null;
private final AgentManager agentManager;
- private final JobProfileDb jobConfDb;
+ private JobProfileDb jobConfDb;
private final AgentConfiguration conf;
private ConcurrentHashMap<String, ConcurrentHashMap<String, Long>>
jobTaskPositionMap;
private PositionManager(AgentManager agentManager) {
this.conf = AgentConfiguration.getAgentConf();
this.agentManager = agentManager;
- this.jobConfDb = agentManager.getJobManager().getJobConfDb();
+ // this.jobConfDb = agentManager.getJobManager().getJobConfDb();
Review Comment:
please remove this
##########
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/HeartbeatManager.java:
##########
@@ -181,34 +172,24 @@ private HeartbeatMsg buildHeartbeatMsg() {
heartbeatMsg.setNodeGroup(nodeGroup);
}
- Map<String, JobWrapper> jobWrapperMap = jobmanager.getJobs();
- List<GroupHeartbeat> groupHeartbeats = Lists.newArrayList();
- List<StreamHeartbeat> streamHeartbeats = Lists.newArrayList();
- List<String> jobIds = Lists.newArrayList();
- jobWrapperMap.values().forEach(jobWrapper -> {
- Job job = jobWrapper.getJob();
- JobProfile jobProfile = job.getJobConf();
- jobIds.add(jobProfile.getInstanceId());
- final String groupId = jobProfile.get(JOB_GROUP_ID);
- final String streamId = jobProfile.get(JOB_STREAM_ID);
- State currentState = jobWrapper.getCurrentState();
- String status = currentState.name();
- GroupHeartbeat groupHeartbeat = new GroupHeartbeat();
- groupHeartbeat.setInlongGroupId(groupId);
- groupHeartbeat.setStatus(status);
- groupHeartbeats.add(groupHeartbeat);
-
- StreamHeartbeat streamHeartbeat = new StreamHeartbeat();
- streamHeartbeat.setInlongGroupId(groupId);
- streamHeartbeat.setInlongStreamId(streamId);
- streamHeartbeat.setStatus(status);
- streamHeartbeats.add(streamHeartbeat);
- });
-
- heartbeatMsg.setGroupHeartbeats(groupHeartbeats);
- heartbeatMsg.setStreamHeartbeats(streamHeartbeats);
-
- LOGGER.info("heartbeat jobIds {} heartbeatMsg {}", jobIds,
heartbeatMsg);
+ /*
+ * Map<String, JobWrapper> jobWrapperMap = taskManager.getJobs();
List<GroupHeartbeat> groupHeartbeats =
Review Comment:
please remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
