healchow commented on code in PR #9242:
URL: https://github.com/apache/inlong/pull/9242#discussion_r1387557303
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/iceberg/IcebergSinkRequest.java:
##########
@@ -64,4 +64,7 @@ public class IcebergSinkRequest extends SinkRequest {
@ApiModelProperty("Primary key")
private String primaryKey;
+ @ApiModelProperty("append mode, UPSERT or APPEND")
Review Comment:
Do we need to add a pattern to limit the value of this field?
Such as:
```java
@ApiModelProperty("Append mode, UPSERT or APPEND")
@Pattern(regexp = "(?i)(UPSERT|APPEND)", message = "Invalid append mode")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
