healchow commented on code in PR #9287: URL: https://github.com/apache/inlong/pull/9287#discussion_r1396859891
########## inlong-manager/manager-client/src/test/java/org/apache/inlong/manager/client/api/inner/ClientFactoryTest.java: ########## @@ -37,6 +37,7 @@ import org.apache.inlong.manager.common.consts.SinkType; import org.apache.inlong.manager.common.consts.SourceType; import org.apache.inlong.manager.common.enums.ClusterType; +import org.apache.inlong.manager.common.enums.KafkaOffset; Review Comment: The KafkaOffset class is only used by Kafka and is not intended for public use. Therefore, I don't think it's appropriate to place it in the common package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
