baomingyu commented on code in PR #9522:
URL: https://github.com/apache/inlong/pull/9522#discussion_r1436950002
##########
inlong-sort/sort-formats/format-base/src/main/java/org/apache/inlong/sort/formats/base/TableFormatDeserializer.java:
##########
@@ -17,13 +17,42 @@
package org.apache.inlong.sort.formats.base;
-import org.apache.flink.api.common.functions.FlatMapFunction;
+import org.apache.flink.api.common.functions.RichFlatMapFunction;
import org.apache.flink.api.java.typeutils.ResultTypeQueryable;
+import org.apache.flink.configuration.Configuration;
import org.apache.flink.types.Row;
+import java.util.Map;
+
/**
* The deserializer for a given format.
*/
-public interface TableFormatDeserializer extends FlatMapFunction<byte[], Row>,
ResultTypeQueryable<Row> {
+public abstract class TableFormatDeserializer extends
RichFlatMapFunction<byte[], Row>
+ implements
+ ResultTypeQueryable<Row> {
+
+ private static final long serialVersionUID = 1L;
+
+ private static final String FORMAT_METRIC_GROUP_NAME = "format";
Review Comment:
delete
##########
inlong-sort/sort-formats/format-base/src/main/java/org/apache/inlong/sort/formats/base/TableFormatConstants.java:
##########
@@ -38,6 +39,11 @@ public class TableFormatConstants {
public static final char DEFAULT_DELIMITER = ',';
public static final char DEFAULT_ENTRY_DELIMITER = '&';
public static final char DEFAULT_KV_DELIMITER = '=';
+ public static final Character DEFAULT_LINE_DELIMITER = null;
+ public static final Character DEFAULT_ESCAPE_CHARACTER = null;
+ public static final Character DEFAULT_QUOTE_CHARACTER = null;
+ public static final String DEFAULT_NULL_LITERAL = null;
public static final boolean DEFAULT_IGNORE_ERRORS = false;
public static final String DEFAULT_CHARSET = "UTF-8";
+ public static final int DEFAULT_BYTE_ARRAY_STREAM_LENGTH = 2048;
Review Comment:
delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
