baomingyu commented on PR #9789: URL: https://github.com/apache/inlong/pull/9789#issuecomment-1984926600
> I found that we already have several tests for `splitKv` or `splitCsv` > > https://github.com/apache/inlong/blob/master/inlong-sort/sort-formats/format-rowdata/format-rowdata-kv/src/test/java/org/apache/inlong/sort/formats/kv/KvUtilsTest.java > > https://github.com/apache/inlong/blob/master/inlong-sort/sort-formats/format-row/format-kv/src/test/java/org/apache/inlong/sort/formats/kv/KvUtilsTest.java > > https://github.com/apache/inlong/blob/master/inlong-sort/sort-formats/format-row/format-csv/src/test/java/org/apache/inlong/sort/formats/csv/CsvUtilsTest.java > > Is it necessacery to add a new test class? All existing tests are tests of data in kv and csv formats that combine expected rules. The new ones are scenarios that can parse data in kv and csv formats that do not comply with the rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
