dockerzhang commented on code in PR #9805:
URL: https://github.com/apache/inlong/pull/9805#discussion_r1522472066
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/TaskProfileDto.java:
##########
@@ -209,6 +213,21 @@ private static KafkaJob getKafkaJob(DataConfig
dataConfigs) {
return kafkaJob;
}
+ private static PulsarTask getPulsarJob(DataConfig dataConfig) {
Review Comment:
```suggestion
private static PulsarTask getPulsarTask(DataConfig dataConfig) {
```
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/constant/TaskConstants.java:
##########
@@ -117,6 +117,14 @@ public class TaskConstants extends CommonConstants {
public static final String JOB_KAFKA_READ_TIMEOUT =
"job.kafkaJob.read.timeout";
public static final String TASK_KAFKA_AUTO_COMMIT_OFFSET_RESET =
"task.kafkaJob.autoOffsetReset";
+ // Pulsar job
Review Comment:
```suggestion
// Pulsar task
```
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/TaskProfileDto.java:
##########
@@ -456,6 +475,13 @@ public static TaskProfile convertToTaskProfile(DataConfig
dataConfig) {
task.setSource(KAFKA_SOURCE);
profileDto.setTask(task);
break;
+ case PULSAR:
+ task.setTaskClass(DEFAULT_PULSAR_TASK);
+ PulsarTask pulsarTask = getPulsarJob(dataConfig);
Review Comment:
```suggestion
PulsarTask pulsarTask = getPulsarTask(dataConfig);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
