fuweng11 commented on code in PR #9865:
URL: https://github.com/apache/inlong/pull/9865#discussion_r1535006930


##########
inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/listener/StartupSortListener.java:
##########
@@ -98,6 +99,14 @@ public ListenerResult listen(WorkflowContext context) throws 
Exception {
         }
 
         for (InlongStreamInfo streamInfo : streamInfos) {
+            boolean isOfflineSync = InlongConstants.DATASYNC_OFFLINE_MODE
+                    
.equals(groupResourceForm.getGroupInfo().getInlongGroupMode());
+            // do not submit flink job if the group mode is offline and the 
stream is not config successfully
+            if (isOfflineSync && 
!StreamParseUtils.isStreamConfigSuccess(streamInfo)) {

Review Comment:
   Ditto.



##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/consts/InlongConstants.java:
##########
@@ -141,6 +141,8 @@ public class InlongConstants {
      */
     public static final String DATAFLOW = "dataflow";
 
+    public static final String STREAM_CONFIG_STATUS = "stream.config.status";

Review Comment:
   Please rename, this information is only used to determine whether scheduling 
is enabled, and the naming of this parameter does not match its actual meaning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to