Re: [PR] [INLONG-9866][Sort] Add end to end test case(redis to redis) for sort-connector-redis-v1.15. [inlong]

Mon, 01 Apr 2024 06:01:43 -0700 


XiaoYou201 commented on code in PR #9869:
URL: https://github.com/apache/inlong/pull/9869#discussion_r1546309783


##########
inlong-sort/sort-end-to-end-tests/sort-end-to-end-tests-v1.15/pom.xml:
##########
@@ -241,7 +254,7 @@
                         <goals>
                             <goal>copy</goal>
                         </goals>
-                        <phase>pre-integration-test</phase>
+                        <phase>validate</phase>

Review Comment:
   Because maven lifecycle does not have a pre-integration-test phase, and this 
phaseis not defined in the code, the end-to-end module cannot add the 
sort-connector jar to dependencies when packaging.So it need to copy 
dependencies to target directory before package.Some pictures as follow.
   
   ![I_H7ZUTJ40L{2GLC8 
JN$PP](https://github.com/apache/inlong/assets/58425449/4bdd11d6-8138-450f-8469-bb86dfa51029)
   
   
![image](https://github.com/apache/inlong/assets/58425449/52d6ccea-b075-469a-a597-0ff56606213b)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to