justinwwhuang commented on code in PR #9916: URL: https://github.com/apache/inlong/pull/9916#discussion_r1547197319
########## inlong-agent/agent-installer/conf/installer.properties: ########## @@ -18,21 +18,21 @@ ####################### # common config ####################### -local.ip=127.0.0.1 +agent.local.ip=127.0.0.1 agent.enable.oom.exit=false ############################ # manager config ############################ -manager.addr=http://127.0.0.1:8083 -manager.auth.secretId= -manager.auth.secretKey= +agent.manager.addr=http://127.0.0.1:8083 +agent.manager.auth.secretId= +agent.manager.auth.secretKey= ############################ # cluster config for automatically report and register ############################ -cluster.tag=default_cluster -cluster.name=default_agent +agent.cluster.tag=default_cluster +agent.cluster.name=default_agent ############################ # audit config Review Comment: forgot ########## inlong-agent/agent-installer/conf/installer.properties: ########## @@ -18,21 +18,21 @@ ####################### # common config ####################### -local.ip=127.0.0.1 +agent.local.ip=127.0.0.1 agent.enable.oom.exit=false ############################ # manager config ############################ -manager.addr=http://127.0.0.1:8083 -manager.auth.secretId= -manager.auth.secretKey= +agent.manager.addr=http://127.0.0.1:8083 +agent.manager.auth.secretId= +agent.manager.auth.secretKey= ############################ # cluster config for automatically report and register ############################ -cluster.tag=default_cluster -cluster.name=default_agent +agent.cluster.tag=default_cluster +agent.cluster.name=default_agent ############################ # audit config Review Comment: Two points, 1. These two configurations are not exclusive to agents; 2 agents also use this configuration name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
