vernedeng commented on code in PR #9933:
URL: https://github.com/apache/inlong/pull/9933#discussion_r1555185807
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/cluster/agent/AgentClusterNodeDTO.java:
##########
@@ -42,16 +50,57 @@
@ApiModel("Agent cluster node info")
public class AgentClusterNodeDTO {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(AgentClusterNodeDTO.class);
+
@ApiModelProperty(value = "Agent group name")
private String agentGroup;
+ @ApiModelProperty(value = "Module id list")
+ private List<Integer> moduleIdList;
+
+ @ApiModelProperty(value = "Agent restart time")
+ private Integer agentRestartTime = 0;
+
+ @ApiModelProperty(value = "Install restart time")
+ private Integer installRestartTime = 0;
+
+ @ApiModelProperty("History list of module")
+ private List<ModuleHistory> moduleHistoryList;
+
/**
* Get the dto instance from the request
*/
public static AgentClusterNodeDTO getFromRequest(AgentClusterNodeRequest
request, String extParams) {
- AgentClusterNodeDTO dto = StringUtils.isNotBlank(extParams)
- ? AgentClusterNodeDTO.getFromJson(extParams)
- : new AgentClusterNodeDTO();
+ AgentClusterNodeDTO dto;
+ if (StringUtils.isNotBlank(extParams)) {
+ dto = AgentClusterNodeDTO.getFromJson(extParams);
Review Comment:
Ensure all variables are not null in `AgentClusterNodeDTO.getFromJson `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
