Re: [PR] [INLONG-9402][Sort] Solve errors in UT test logs for sort-end-to-end-tests, but UT results show as successful [inlong]

Wed, 10 Apr 2024 00:07:23 -0700 


XiaoYou201 commented on code in PR #9940:
URL: https://github.com/apache/inlong/pull/9940#discussion_r1558956648


##########
inlong-sort/sort-end-to-end-tests/sort-end-to-end-tests-v1.15/src/test/java/org/apache/inlong/sort/tests/utils/FlinkContainerTestEnv.java:
##########
@@ -165,8 +134,8 @@ public void submitSQLJob(String sqlFile, Path... jars)
         ExecResult execResult =
                 jobManager.execInContainer("bash", "-c", String.join(" ", 
commands));
         LOG.info(execResult.getStdout());
-        LOG.error(execResult.getStderr());

Review Comment:
   I put the code for printing logs into the following if statement.Beacause if 
There were error in running, the execResult.getExitCode() will not equal 0,So, 
It will still print logs.
   
   
![image](https://github.com/apache/inlong/assets/58425449/e35eb845-7b6c-4d41-b114-cfed2a77bbaf)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to