aloyszhang commented on code in PR #10011:
URL: https://github.com/apache/inlong/pull/10011#discussion_r1570577947
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/file/AbstractSource.java:
##########
@@ -128,8 +130,11 @@ public void init(InstanceProfile profile) {
initOffset();
registerMetric();
initExtendHandler();
+ initSource(profile);
}
+ protected abstract void initSource(InstanceProfile profile);
Review Comment:
Not all sources need `initSource`, how about adding a default implement of
here which does nothing, and sources like `KakfaSource` override the method
`initSource` if need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
