justinwwhuang commented on code in PR #10013: URL: https://github.com/apache/inlong/pull/10013#discussion_r1570642290
########## inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/task/AbstractTask.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.agent.plugin.task; + +import org.apache.inlong.agent.conf.InstanceProfile; +import org.apache.inlong.agent.conf.TaskProfile; +import org.apache.inlong.agent.constant.TaskConstants; +import org.apache.inlong.agent.core.instance.ActionType; +import org.apache.inlong.agent.core.instance.InstanceAction; +import org.apache.inlong.agent.core.instance.InstanceManager; +import org.apache.inlong.agent.core.task.TaskManager; +import org.apache.inlong.agent.db.Db; +import org.apache.inlong.agent.metrics.audit.AuditUtils; +import org.apache.inlong.agent.plugin.file.Task; +import org.apache.inlong.agent.state.State; +import org.apache.inlong.agent.utils.AgentUtils; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.List; + +public abstract class AbstractTask extends Task { + + private static final Logger LOGGER = LoggerFactory.getLogger(AbstractTask.class); + public static final int CORE_THREAD_SLEEP_TIME = 1000; + public static final int CORE_THREAD_PRINT_TIME = 10000; + protected TaskProfile taskProfile; + protected Db basicDb; + protected TaskManager taskManager; + private InstanceManager instanceManager; + protected volatile boolean running = false; + protected boolean initOK = false; + protected long lastPrintTime = 0; + + @Override + public void init(Object srcManager, TaskProfile taskProfile, Db basicDb) throws IOException { + taskManager = (TaskManager) srcManager; + this.taskProfile = taskProfile; + this.basicDb = basicDb; + instanceManager = new InstanceManager(taskProfile.getTaskId(), taskProfile.getInt(TaskConstants.FILE_MAX_NUM), + basicDb, taskManager.getTaskDb()); + try { + instanceManager.start(); + } catch (Exception e) { + LOGGER.error("start instance manager error: ", e); + } + initTask(); + initOK = true; + } + + protected abstract void initTask(); + + protected abstract void releaseTask(); Review Comment: Yes, some scenarios of releaseTask do not require implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
