XiaoYou201 commented on code in PR #10040:
URL: https://github.com/apache/inlong/pull/10040#discussion_r1574546117


##########
inlong-tubemq/tubemq-client-twins/tubemq-client-go/config/config.go:
##########
@@ -620,3 +638,17 @@ func WithConsumePosition(consumePosition int) Option {
                c.Consumer.ConsumePosition = consumePosition
        }
 }
+
+// WithLogLevel set log level
+func WithLogLevel(level string) Option {
+       return func(c *Config) {
+               c.Log.LogLevel = level
+       }
+}
+
+// WithLogPath set log path
+func WithLogPath(path string) Option {
+       return func(c *Config) {
+               c.Log.LogPath = path
+       }
+}

Review Comment:
   Thanks suggestion, I add some codes to make this configuration take effect.



##########
inlong-tubemq/tubemq-client-twins/tubemq-client-go/config/config.go:
##########
@@ -143,6 +144,10 @@ type Config struct {
                // AfterFail is the heartbeat timeout after a heartbeat failure.
                AfterFail time.Duration
        }
+       Log struct {
+               LogPath  string
+               LogLevel string

Review Comment:
   Thanks suggestion, fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to