luchunliang commented on code in PR #10042:
URL: https://github.com/apache/inlong/pull/10042#discussion_r1575578830
##########
inlong-common/src/main/java/org/apache/inlong/common/pojo/sort/dataflow/field/format/DateFormatInfo.java:
##########
@@ -126,11 +137,7 @@ public Date deserialize(String text) throws ParseException
{
return new Date(millis);
}
default: {
- if (simpleDateFormat == null) {
- throw new IllegalStateException();
- }
-
- java.util.Date jDate = simpleDateFormat.parse(text.trim());
+ java.util.Date jDate = get().parse(text.trim());
Review Comment:
If it is invalid date string, this will throw exception, it is better to
return null or default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
