luchunliang commented on code in PR #10220:
URL: https://github.com/apache/inlong/pull/10220#discussion_r1600868202
##########
inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/cls/ClsSinkContext.java:
##########
@@ -104,26 +97,25 @@ public void reload() {
}
});
- SortTaskConfig newSortTaskConfig =
SortClusterConfigHolder.getTaskConfig(taskName);
+ SortTaskConfig newSortTaskConfig =
SortConfigHolder.getTaskConfig(taskName);
if (newSortTaskConfig == null ||
newSortTaskConfig.equals(sortTaskConfig)) {
return;
}
LOG.info("get new SortTaskConfig:taskName:{}:config:{}", taskName,
new ObjectMapper().writeValueAsString(newSortTaskConfig));
this.sortTaskConfig = newSortTaskConfig;
Review Comment:
If requestNodeConfig.getVersion() < clsNodeConfig.getVersion(), reload
function can directly return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
