shuiqingliu commented on code in PR #10390:
URL: https://github.com/apache/inlong/pull/10390#discussion_r1637419710
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cmd/shell/ShellExecutorImpl.java:
##########
@@ -92,11 +93,26 @@ private static boolean HasException(String str) {
return false;
}
+ public void syncExec(String shellPath, boolean includeEmptyParams,
String... params) {
Review Comment:
Based on the current design of the `execRemote` method, it calls the expect
script using hard-coded values. This script receives a password parameter. If
the password parameter is empty, it will be removed by the original merge
method, causing parameter mapping errors in the expect script. Currently, the
SSH key authentication method does not require a password, so it is indeed
necessary to retain the empty string parameter when invoke the exec_cmd.exp
script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
