EMsnap commented on code in PR #10393:
URL: https://github.com/apache/inlong/pull/10393#discussion_r1637663163
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/DynamicKafkaDeserializationSchema.java:
##########
@@ -131,12 +140,21 @@ public void deserialize(ConsumerRecord<byte[], byte[]>
record, Collector<RowData
if (keyDeserialization != null) {
keyDeserialization.deserialize(record.key(), keyCollector);
}
-
// project output while emitting values
outputCollector.inputRecord = record;
outputCollector.physicalKeyRows = keyCollector.buffer;
- outputCollector.outputCollector =
- sourceMetricData == null ? collector : new
MetricsCollector<>(collector, sourceMetricData);
+ if (sourceMetricData != null) {
+ MetricsCollector<RowData> metricsCollector = new
MetricsCollector<>(collector, sourceMetricData);
+ if (consumeTimeIndex != -1) {
Review Comment:
please extract method for consumeTimeIndex and getting time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
