fuweng11 commented on code in PR #10445:
URL: https://github.com/apache/inlong/pull/10445#discussion_r1644394405
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -239,7 +254,18 @@ public Boolean exist(String groupId) {
Preconditions.expectNotNull(groupId,
ErrorCodeEnum.GROUP_ID_IS_EMPTY.getMessage());
InlongGroupEntity entity = groupMapper.selectByGroupId(groupId);
LOGGER.debug("success to check inlong group {}, exist? {}", groupId,
entity != null);
- return entity != null;
+ if (entity == null) {
+ return false;
+ }
+ checkOfflineSyncScheduleExist(entity, groupId);
+ return true;
+ }
+
+ private void checkOfflineSyncScheduleExist(InlongGroupEntity entity,
String groupId) {
+ // check schedule info for offline sync
+ if (DATASYNC_OFFLINE_MODE.equals(entity.getInlongGroupMode()) &&
!scheduleOperator.scheduleInfoExist(groupId)) {
+ LOGGER.warn("Schedule info not found for group={}", groupId);
Review Comment:
Please throw exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
