gunli opened a new pull request, #10674:
URL: https://github.com/apache/inlong/pull/10674
<!-- Prepare a Pull Request
Change the title of pull request refer to the following example:
[INLONG-XYZ][Component] Title of the pull request
-->
<!-- Specify the issue this pull request going to fix.
The following *XYZ* should be replaced by the actual [GitHub
Issue](https://github.com/apache/inlong/issues) number)-->
Fixes #11670
### Motivation
<!--Explain here the context, and why you're making that change. What is the
problem you're trying to solve.-->
There is a potential block bug in the Golang SDK:
In the callback of conn.AsyncWrite() we may call worker.updateConn(),
updateConn() may try to open new conn in some case, if so, it will call
gnet.Client.Dial(), but gnet.Client.Dial() will be blocked unitl gnet event
loop mark the conn is opened, but now the event loop is running in
conn.AsyncWrite()'s callback:
conn.AsyncWrite()'s
callback-->worker.updateConn()-->gnet.Client.Dial()-->waiting for
conn.AsyncWrite()'s callback to return.
### Modifications
<!--Describe the modifications you've done.-->
1. update conn async in the conn.AsyncWrite() callback;
2. update conn async when conn is closed.
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up
issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
