fuweng11 commented on code in PR #11545:
URL: https://github.com/apache/inlong/pull/11545#discussion_r1856842870
##########
inlong-manager/manager-schedule/src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleEngine.java:
##########
@@ -84,6 +84,9 @@ public class DolphinScheduleEngine implements ScheduleEngine {
@PostConstruct
public void init() {
this.projectBaseUrl = dolphinUrl + DS_PROJECT_URL;
+ String[] urlInfo = managerUrl.split(":");
Review Comment:
Ditto.
##########
inlong-manager/manager-schedule/src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleEngine.java:
##########
@@ -84,6 +84,9 @@ public class DolphinScheduleEngine implements ScheduleEngine {
@PostConstruct
public void init() {
this.projectBaseUrl = dolphinUrl + DS_PROJECT_URL;
+ String[] urlInfo = managerUrl.split(":");
Review Comment:
```suggestion
String[] urlInfo = managerUrl.split(InlongConstants.COLON);
```
##########
inlong-manager/manager-schedule/src/main/java/org/apache/inlong/manager/schedule/airflow/AirflowScheduleEngine.java:
##########
@@ -96,9 +96,10 @@ private void initConnection() throws Exception {
AirflowResponse<AirflowConnection> response = serverClient.sendRequest(
new AirflowConnectionGetter(airflowConfig.getConnectionId()));
if (!response.isSuccess()) {
+ String[] urlInfo = airflowConfig.getManagerUrl().split(":");
Review Comment:
Need to check the URL, otherwise NPE will occur.
##########
inlong-manager/manager-schedule/src/main/java/org/apache/inlong/manager/schedule/airflow/AirflowScheduleEngine.java:
##########
@@ -96,9 +96,10 @@ private void initConnection() throws Exception {
AirflowResponse<AirflowConnection> response = serverClient.sendRequest(
new AirflowConnectionGetter(airflowConfig.getConnectionId()));
if (!response.isSuccess()) {
+ String[] urlInfo = airflowConfig.getManagerUrl().split(":");
Review Comment:
```suggestion
String[] urlInfo =
airflowConfig.getManagerUrl().split(InlongConstants.COLON);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
